Two translation bugs found in Apostrophe theme
-
Hi everyone,
I’m using the Apostrophe theme. I had trouble with some translations not done correctly even with a complete .po file so I went digging into the code. Here’s what I found:
– in footer.php, line 24, esc_html__() function is not used with the right arguments. Should be
printf( esc_html__( 'Proudly powered by %s', 'apostrophe' ), 'WordPress' );– in comments.php, line 26, there’s an argument missing. Should be
esc_html( _nx( 'One comment', '%s comments', get_comments_number(), 'apostrophe', 'apostrophe' ) ),Hope this helps. :)
(there’s still a non-translated “Proudly powered by” displaying on the main page footer with infinite scrolling but I was not able to find why)
The blog I need help with is: (visible only to logged in users)
-
Please type modlook into the sidebar tags on this thread for Staff help. How do I get a Moderator/Staff reply for my question? https://en.support.wordpress.com/getting-help-in-the-forums/#how-do-i-get-a-moderatorstaff-reply-for-my-question Then please subscribe to this thread so you are notified when they respond. To subscribe look in the sidebar of this thread, find the subscribe to topics link and click it.
-
-
Yes, but now you are no longer new and can begin to learn how to discern which questions require Staff support and which ones Volunteers like me can answer. :)
-
P.S. We do have a Translations Forum at https://en.forums.wordpress.com/forum/translations
and one starts a new thread there by using this link https://en.forums.wordpress.com/forum/translations#postform ;) -
Concerning the Infinite Scroller (jetpack module) non-translating string bug it may have something to do with line 1215 in infinite.php which looks like this:
$credits = '<a href="http://wordpress.org/" rel="generator">Proudly powered by WordPress</a> ';It seems this part of $credits is not passed to any translating function. Moreover there’s no translation for that part of the text in Jetpack .po files (there’s one for the next part of the string anyway).
-
Hi there,
Some strings in the Apostrophe theme (such as the comment string you mentioned) aren’t translated into French yet. You can suggest translations for those untranslated strings in GlotPress here:
Once those strings are translated, they can be approved and launched so you’ll see them on your site at https://lesnewsdusysteme.wordpress.com/.
-
Sorry, I should have been more specific about this. I was referring to a WP.org blog on its dedicated server, and not the one you mentioned (I’m currently in transition between the two — see the Redirect Site upgrade I’m trying to get). I completed the .po file for fr_FR language and generated the .mo file with Poedit. When I found there was still some untranslated strings I went into the code and found three bugs.
Since Apostrophe is a theme designed by WP.com team I thought it was the right place to do a bug report. But if it’s not, I will gladly report them elsewhere. :)
-
Ah, I understand now.
The translations bundled with the theme for self-hosted sites come from GlotPress on WordPress.com, so once the comments string is translated here it can be included in the self-hosted theme:
All of the required arguments are included in that string, but it isn’t translated yet.
I see what you mean about the string “Proudly powered by WordPress” not being translatable in the infinite scroll module in Jetpack. I’ve reported that to our Jetpack team so they can take a look at that.
-
Please report the other two bugs as well if possible! (but that would be to the Apostrophe team, since Jetpack is not interfering here)
As I said, I completed the translations for Apostrophe theme by myself with Poedit, then generated .po and .mo files for fr_FR, uploaded them on my server, and there were still untranslated strings displaying, basically “One comment”/”X comments” and “Proudly powered by”. The only solution at that point was to get into the code and check for bugs. There were two. :)
You’ll find my .po file here if you want to test it out (all strings needing a translation have them): http://ow.ly/QO7SO
-
Sure thing! I reported the translation issues specific to the Apostrophe theme to our theme developers so they can investigate that further. Thanks for letting us know.
-
-
Hi there! We’ve recently released a patch for Apostrophe that solves the translation string issue. The “x comments” string would need to be translated in order to show up (you can see, for example, the French translation for the string is missing in GlotPress here: https://translate.wordpress.com/projects/wpcom/themes/apostrophe/fr/default?filters%5Boriginal_id%5D=197878)
Once the translation is available, this string should be properly translated now.
- The topic ‘Two translation bugs found in Apostrophe theme’ is closed to new replies.
WordPress.com Forums 